[SE-0494] update proposal with lsg modifications #2986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lorentey Did these look correct to you? |
|
@rjmccall BTW… did LSG accept these new types on the condition we carry over the explicit semantic guarantees from the existing types?
|
rjmccall
added
the
LSG
vanvoorden
changed the title
vanvoorden
changed the title
vanvoorden
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to SE-0494 based on LSG modifications:
New Name
We migrate
isIdentical(to:)toisTriviallyIdentical(to:).New Types
We add
isTriviallyIdentical(to:)to the following concrete types:UnsafeBufferPointerUnsafeMutableBufferPointerUnsafeMutableRawBufferPointerUnsafeRawBufferPointerUTF8SpanSpanRawSpanSwiftUI Example
This is in response to community feedback asking for some more details on our SwiftUI sample code.1 This is only a change to try and improve the sample code with a little more information: this is not intended to be a change for our design.
Footnotes
https://forums.swift.org/t/se-0494-add-isidentical-to-methods-for-quick-comparisons-to-concrete-types/82296/22 ↩